Conversation
Member
Author
|
Getting tests to pass here on v0.6 will require JuliaLang/julia#20200 to get fixed. |
Member
Author
|
This branch contains a grab-bag of useful improvements/fixes. I might merge this soon (as long as tests pass on v0.5) even though v0.6 tests aren't passing because there's not much I can do about JuliaLang/julia#20200 for the time being. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It makes sense to pull out some of these changes from the jr/mnist branch and merge them separately (after which I'll rebase jr/mnist on top of master). This way, I can focus on some of the compat fixes we need for v0.6 without getting tied up in the MNIST example.
There's still some convert issue on v0.6 I need to fix, and I also need to tag new versions of Calculus and ForwardDiff (so I can bump the version requirements here).