correct the seeding order for seeded_reverse_pass! functions#60
Merged
correct the seeding order for seeded_reverse_pass! functions#60
Conversation
This was referenced Mar 15, 2017
jrevels
force-pushed
the
jr/fixseedorder
branch
from
81f9fb3 to
cc2a76d
Compare
Member
Author
|
Tests should pass here once JuliaLang/METADATA.jl#8357 is merged |
|
Rerun tests? PR is merged at metadata |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #59. Test is added here. We'll have to re-run Travis once that's merged and tagged to get representative testing in this PR.
Funnily, enough, this also reveals similar bugs in both ForwardDiff and Calculus - both of them appear to get the wrong answer for the Jacobian of the identity. I've checked locally that this PR enables ReverseDiff to get the correct answer, but once the DiffBase PR is merged, tests will fail here, since ReverseDiff is checking against ForwardDiff, which checks against Calculus.
I'll start working on bug fixes for those packages as well.