Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1833 1833
=========================================
Hits 1833 1833 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gdalle
requested changes
Feb 17, 2025
Member
gdalle
left a comment
There was a problem hiding this comment.
Thanks for this initiative!
I see two ways to make this even better:
- Say a couple words about each variant of coloring instead of just dropping the result on the user. What problem is each one supposed to solve? How does it compare to the previous ones? In particular, the point of bicoloring is not so obvious in this case (since the matrix is symmetric, it will always be worse than symmetric coloring?)
- Can we avoid carrying and versioning an
mtxfile in the repo? We could download one on the fly instead with MatrixDepot.jl.
gdalle
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #95
cc @adrhill
--> preview <--
Add the tutorials prepared for AD2024 in the documentation, updated for PPoPP25 next month, and using the latest visualization features of SMC.jl.
Adrian and Guillaume, is it already possible to display the sparsity pattern on which we apply a coloring with all nnz in black?
A workaround will be to set all colors to black but it could be nice to have an option
sparsity_patterninshow_colors(if it doesn't exist already).