Skip to content

Replace num_edges_per_tree by tree_edge_indices in TreeSet#237

Merged
gdalle merged 3 commits intomainfrom
better_ptr
Apr 7, 2025
Merged

Replace num_edges_per_tree by tree_edge_indices in TreeSet#237
gdalle merged 3 commits intomainfrom
better_ptr

Conversation

@amontoison
Copy link
Copy Markdown
Collaborator

Improve the readability of what was done in #228.
I found that the need to update a variable first in various specific places (at the end of for loops) in the code was quite difficult to read and error-prone.
Things will become even more complex with #233, so I prefer to make these modifications first.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (45aa7aa) to head (7b67d58).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #237   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1785      1781    -4     
=========================================
- Hits          1785      1781    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gdalle gdalle merged commit 5572dab into main Apr 7, 2025
6 checks passed
@gdalle gdalle deleted the better_ptr branch April 7, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants