Skip to content

Update how we use visited_trees in TreeSet#245

Merged
gdalle merged 1 commit intomainfrom
visited_trees_acyclic
Apr 10, 2025
Merged

Update how we use visited_trees in TreeSet#245
gdalle merged 1 commit intomainfrom
visited_trees_acyclic

Conversation

@amontoison
Copy link
Copy Markdown
Collaborator

@amontoison amontoison commented Apr 10, 2025

No description provided.

@amontoison amontoison requested a review from gdalle April 10, 2025 06:16
@amontoison amontoison added the benchmark Run benchmarks on PR label Apr 10, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (744827d) to head (138b19a).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #245   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1830      1822    -8     
=========================================
- Hits          1830      1822    -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2025

Benchmark Results

main 138b19a... main/138b19ae7a4121...
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.002 1.92 ± 0.014 ms 1.91 ± 0.015 ms 1
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.005 4.38 ± 0.031 ms 4.41 ± 0.037 ms 0.992
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.01 9.78 ± 0.09 ms 9.92 ± 0.07 ms 0.986
coloring/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 2.06 ± 0.066 s 2.22 ± 0.11 s 0.927
coloring/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 0.293 ± 0.0069 s 0.29 ± 0.0041 s 1.01
coloring/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 0.889 ± 0.032 s 0.795 ± 0.073 s 1.12
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 2.93 ± 0.024 ms 2.86 ± 0.019 ms 1.03
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 7.7 ± 0.061 ms 7.56 ± 0.061 ms 1.02
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 18.4 ± 0.16 ms 18.1 ± 0.14 ms 1.02
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 4.13 ± 0.15 s 4.29 ± 0.29 s 0.962
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 0.498 ± 0.042 s 0.49 ± 0.023 s 1.02
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 2.24 ± 0.32 s 1.44 ± 0.038 s 1.55
coloring/nonsymmetric/column/direct/n=1000/p=0.002 0.495 ± 0.01 ms 0.49 ± 0.01 ms 1.01
coloring/nonsymmetric/column/direct/n=1000/p=0.005 1.22 ± 0.0094 ms 1.21 ± 0.01 ms 1.01
coloring/nonsymmetric/column/direct/n=1000/p=0.01 3.02 ± 0.014 ms 3 ± 0.014 ms 1.01
coloring/nonsymmetric/column/direct/n=100000/p=0.0001 0.529 ± 0.0076 s 0.518 ± 0.014 s 1.02
coloring/nonsymmetric/column/direct/n=100000/p=2.0e-5 0.0809 ± 0.00065 s 0.0812 ± 0.001 s 0.996
coloring/nonsymmetric/column/direct/n=100000/p=5.0e-5 0.214 ± 0.0056 s 0.204 ± 0.0027 s 1.05
coloring/nonsymmetric/row/direct/n=1000/p=0.002 0.476 ± 0.011 ms 0.486 ± 0.011 ms 0.98
coloring/nonsymmetric/row/direct/n=1000/p=0.005 1.19 ± 0.012 ms 1.22 ± 0.011 ms 0.976
coloring/nonsymmetric/row/direct/n=1000/p=0.01 2.97 ± 0.017 ms 3.08 ± 0.017 ms 0.964
coloring/nonsymmetric/row/direct/n=100000/p=0.0001 0.515 ± 0.0083 s 0.562 ± 0.09 s 0.916
coloring/nonsymmetric/row/direct/n=100000/p=2.0e-5 0.0814 ± 0.0013 s 0.0817 ± 0.0018 s 0.996
coloring/nonsymmetric/row/direct/n=100000/p=5.0e-5 0.214 ± 0.009 s 0.207 ± 0.0052 s 1.03
coloring/symmetric/column/direct/n=1000/p=0.002 1.04 ± 0.011 ms 1.04 ± 0.011 ms 1
coloring/symmetric/column/direct/n=1000/p=0.005 2.28 ± 0.014 ms 2.3 ± 0.014 ms 0.994
coloring/symmetric/column/direct/n=1000/p=0.01 4.95 ± 0.031 ms 4.96 ± 0.037 ms 0.997
coloring/symmetric/column/direct/n=100000/p=0.0001 0.764 ± 0.03 s 0.758 ± 0.029 s 1.01
coloring/symmetric/column/direct/n=100000/p=2.0e-5 0.146 ± 0.0011 s 0.147 ± 0.0017 s 0.994
coloring/symmetric/column/direct/n=100000/p=5.0e-5 0.337 ± 0.0047 s 0.339 ± 0.0068 s 0.994
coloring/symmetric/column/substitution/n=1000/p=0.002 1.62 ± 0.013 ms 1.59 ± 0.015 ms 1.02
coloring/symmetric/column/substitution/n=1000/p=0.005 4.02 ± 0.023 ms 3.97 ± 0.023 ms 1.01
coloring/symmetric/column/substitution/n=1000/p=0.01 9.13 ± 0.049 ms 9.1 ± 0.052 ms 1
coloring/symmetric/column/substitution/n=100000/p=0.0001 1.65 ± 0.048 s 1.55 ± 0.14 s 1.06
coloring/symmetric/column/substitution/n=100000/p=2.0e-5 0.228 ± 0.01 s 0.235 ± 0.018 s 0.969
coloring/symmetric/column/substitution/n=100000/p=5.0e-5 0.644 ± 0.032 s 0.625 ± 0.035 s 1.03
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.002 0.147 ± 0.0037 ms 0.144 ± 0.0049 ms 1.02
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.005 0.236 ± 0.0081 ms 0.232 ± 0.0085 ms 1.02
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.01 0.389 ± 0.011 ms 0.381 ± 0.019 ms 1.02
decompress/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 0.0969 ± 0.002 s 0.0941 ± 0.004 s 1.03
decompress/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 0.0341 ± 0.001 s 0.033 ± 0.0019 s 1.03
decompress/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 0.0587 ± 0.00093 s 0.0587 ± 0.001 s 0.999
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 0.145 ± 0.0045 ms 0.148 ± 0.0054 ms 0.976
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 0.278 ± 0.0087 ms 0.284 ± 0.0092 ms 0.978
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 0.568 ± 0.012 ms 0.566 ± 0.012 ms 1
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 0.179 ± 0.0091 s 0.163 ± 0.0079 s 1.1
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 0.0348 ± 0.001 s 0.0334 ± 0.00099 s 1.04
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 0.0692 ± 0.0037 s 0.0637 ± 0.0017 s 1.09
decompress/nonsymmetric/column/direct/n=1000/p=0.002 25.9 ± 1.3 μs 27 ± 1.2 μs 0.96
decompress/nonsymmetric/column/direct/n=1000/p=0.005 0.0485 ± 0.0024 ms 0.0501 ± 0.0025 ms 0.968
decompress/nonsymmetric/column/direct/n=1000/p=0.01 0.0894 ± 0.0042 ms 0.0907 ± 0.0046 ms 0.986
decompress/nonsymmetric/column/direct/n=100000/p=0.0001 26 ± 1 ms 25.5 ± 1 ms 1.02
decompress/nonsymmetric/column/direct/n=100000/p=2.0e-5 4.57 ± 0.25 ms 4.55 ± 0.21 ms 1
decompress/nonsymmetric/column/direct/n=100000/p=5.0e-5 12 ± 0.49 ms 12.1 ± 0.53 ms 0.994
decompress/nonsymmetric/row/direct/n=1000/p=0.002 24.8 ± 1.7 μs 26.1 ± 1.7 μs 0.951
decompress/nonsymmetric/row/direct/n=1000/p=0.005 0.0436 ± 0.0031 ms 0.0446 ± 0.0019 ms 0.978
decompress/nonsymmetric/row/direct/n=1000/p=0.01 0.076 ± 0.0038 ms 0.0767 ± 0.0051 ms 0.992
decompress/nonsymmetric/row/direct/n=100000/p=0.0001 12 ± 0.8 ms 12 ± 0.85 ms 1
decompress/nonsymmetric/row/direct/n=100000/p=2.0e-5 3.23 ± 0.15 ms 3.21 ± 0.14 ms 1.01
decompress/nonsymmetric/row/direct/n=100000/p=5.0e-5 5.97 ± 0.32 ms 6.31 ± 0.44 ms 0.947
decompress/symmetric/column/direct/n=1000/p=0.002 25.1 ± 1.7 μs 27.5 ± 1.3 μs 0.915
decompress/symmetric/column/direct/n=1000/p=0.005 0.0469 ± 0.0022 ms 0.0505 ± 0.0022 ms 0.929
decompress/symmetric/column/direct/n=1000/p=0.01 0.085 ± 0.0052 ms 0.0895 ± 0.0036 ms 0.95
decompress/symmetric/column/direct/n=100000/p=0.0001 21.8 ± 1.1 ms 24.3 ± 1.1 ms 0.897
decompress/symmetric/column/direct/n=100000/p=2.0e-5 3.94 ± 0.32 ms 4.43 ± 0.3 ms 0.891
decompress/symmetric/column/direct/n=100000/p=5.0e-5 10.9 ± 0.66 ms 12.1 ± 0.54 ms 0.9
decompress/symmetric/column/substitution/n=1000/p=0.002 0.0896 ± 0.0029 ms 0.092 ± 0.0036 ms 0.974
decompress/symmetric/column/substitution/n=1000/p=0.005 0.175 ± 0.0069 ms 0.176 ± 0.0082 ms 0.994
decompress/symmetric/column/substitution/n=1000/p=0.01 0.349 ± 0.011 ms 0.35 ± 0.011 ms 0.998
decompress/symmetric/column/substitution/n=100000/p=0.0001 0.092 ± 0.0039 s 0.0903 ± 0.0039 s 1.02
decompress/symmetric/column/substitution/n=100000/p=2.0e-5 22.8 ± 0.39 ms 23.5 ± 0.37 ms 0.971
decompress/symmetric/column/substitution/n=100000/p=5.0e-5 0.0439 ± 0.00079 s 0.0435 ± 0.00068 s 1.01
time_to_load 0.218 ± 0.0036 s 0.217 ± 0.0011 s 1.01
main 138b19a... main/138b19ae7a4121...
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.002 0.475 k allocs: 2.35 MB 0.475 k allocs: 2.35 MB 1
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.005 0.485 k allocs: 3.96 MB 0.485 k allocs: 3.96 MB 1
coloring/nonsymmetric/bidirectional/direct/n=1000/p=0.01 0.495 k allocs: 6.99 MB 0.495 k allocs: 6.99 MB 1
coloring/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 0.555 k allocs: 0.712 GB 0.555 k allocs: 0.712 GB 1
coloring/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 0.525 k allocs: 0.24 GB 0.525 k allocs: 0.24 GB 1
coloring/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 0.545 k allocs: 0.426 GB 0.545 k allocs: 0.426 GB 1
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 0.638 k allocs: 2.82 MB 0.638 k allocs: 2.82 MB 1
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 0.64 k allocs: 4.82 MB 0.64 k allocs: 4.82 MB 1
coloring/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 0.64 k allocs: 8.33 MB 0.64 k allocs: 8.33 MB 1
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 0.645 k allocs: 0.812 GB 0.645 k allocs: 0.812 GB 1
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 0.645 k allocs: 0.272 GB 0.645 k allocs: 0.272 GB 1
coloring/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 0.645 k allocs: 0.472 GB 0.645 k allocs: 0.472 GB 1
coloring/nonsymmetric/column/direct/n=1000/p=0.002 0.135 k allocs: 0.354 MB 0.135 k allocs: 0.354 MB 1
coloring/nonsymmetric/column/direct/n=1000/p=0.005 0.135 k allocs: 0.578 MB 0.135 k allocs: 0.578 MB 1
coloring/nonsymmetric/column/direct/n=1000/p=0.01 0.135 k allocs: 0.967 MB 0.135 k allocs: 0.967 MB 1
coloring/nonsymmetric/column/direct/n=100000/p=0.0001 0.135 k allocs: 0.0931 GB 0.135 k allocs: 0.0931 GB 1
coloring/nonsymmetric/column/direct/n=100000/p=2.0e-5 0.135 k allocs: 0.0335 GB 0.135 k allocs: 0.0335 GB 1
coloring/nonsymmetric/column/direct/n=100000/p=5.0e-5 0.135 k allocs: 0.0558 GB 0.135 k allocs: 0.0558 GB 1
coloring/nonsymmetric/row/direct/n=1000/p=0.002 0.135 k allocs: 0.354 MB 0.135 k allocs: 0.354 MB 1
coloring/nonsymmetric/row/direct/n=1000/p=0.005 0.135 k allocs: 0.578 MB 0.135 k allocs: 0.578 MB 1
coloring/nonsymmetric/row/direct/n=1000/p=0.01 0.135 k allocs: 0.967 MB 0.135 k allocs: 0.967 MB 1
coloring/nonsymmetric/row/direct/n=100000/p=0.0001 0.135 k allocs: 0.0931 GB 0.135 k allocs: 0.0931 GB 1
coloring/nonsymmetric/row/direct/n=100000/p=2.0e-5 0.135 k allocs: 0.0335 GB 0.135 k allocs: 0.0335 GB 1
coloring/nonsymmetric/row/direct/n=100000/p=5.0e-5 0.135 k allocs: 0.0558 GB 0.135 k allocs: 0.0558 GB 1
coloring/symmetric/column/direct/n=1000/p=0.002 0.22 k allocs: 0.583 MB 0.22 k allocs: 0.583 MB 1
coloring/symmetric/column/direct/n=1000/p=0.005 0.23 k allocs: 0.932 MB 0.23 k allocs: 0.932 MB 1
coloring/symmetric/column/direct/n=1000/p=0.01 0.24 k allocs: 1.57 MB 0.24 k allocs: 1.57 MB 1
coloring/symmetric/column/direct/n=100000/p=0.0001 0.3 k allocs: 0.168 GB 0.3 k allocs: 0.168 GB 1
coloring/symmetric/column/direct/n=100000/p=2.0e-5 0.27 k allocs: 0.056 GB 0.27 k allocs: 0.056 GB 1
coloring/symmetric/column/direct/n=100000/p=5.0e-5 0.29 k allocs: 0.0995 GB 0.29 k allocs: 0.0995 GB 1
coloring/symmetric/column/substitution/n=1000/p=0.002 0.4 k allocs: 0.944 MB 0.4 k allocs: 0.944 MB 1
coloring/symmetric/column/substitution/n=1000/p=0.005 0.405 k allocs: 1.64 MB 0.405 k allocs: 1.64 MB 1
coloring/symmetric/column/substitution/n=1000/p=0.01 0.411 k allocs: 2.85 MB 0.411 k allocs: 2.85 MB 1
coloring/symmetric/column/substitution/n=100000/p=0.0001 0.416 k allocs: 0.276 GB 0.416 k allocs: 0.276 GB 1
coloring/symmetric/column/substitution/n=100000/p=2.0e-5 0.41 k allocs: 0.0897 GB 0.41 k allocs: 0.0897 GB 1
coloring/symmetric/column/substitution/n=100000/p=5.0e-5 0.41 k allocs: 0.159 GB 0.41 k allocs: 0.159 GB 1
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/bidirectional/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/bidirectional/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/bidirectional/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/bidirectional/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/bidirectional/substitution/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/nonsymmetric/column/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/column/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/column/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/column/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/column/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/column/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/nonsymmetric/row/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/nonsymmetric/row/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/nonsymmetric/row/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/nonsymmetric/row/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/nonsymmetric/row/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/nonsymmetric/row/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/symmetric/column/direct/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/symmetric/column/direct/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/symmetric/column/direct/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/symmetric/column/direct/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/symmetric/column/direct/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/symmetric/column/direct/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
decompress/symmetric/column/substitution/n=1000/p=0.002 0.045 k allocs: 0.197 MB 0.045 k allocs: 0.197 MB 1
decompress/symmetric/column/substitution/n=1000/p=0.005 0.045 k allocs: 0.419 MB 0.045 k allocs: 0.419 MB 1
decompress/symmetric/column/substitution/n=1000/p=0.01 0.045 k allocs: 0.802 MB 0.045 k allocs: 0.802 MB 1
decompress/symmetric/column/substitution/n=100000/p=0.0001 0.045 k allocs: 0.0782 GB 0.045 k allocs: 0.0782 GB 1
decompress/symmetric/column/substitution/n=100000/p=2.0e-5 0.045 k allocs: 19.1 MB 0.045 k allocs: 19.1 MB 1
decompress/symmetric/column/substitution/n=100000/p=5.0e-5 0.045 k allocs: 0.0409 GB 0.045 k allocs: 0.0409 GB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@gdalle gdalle merged commit fc9d63a into main Apr 10, 2025
7 checks passed
@amontoison amontoison deleted the visited_trees_acyclic branch April 10, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gdalle gdalle gdalle approved these changes

Assignees

No one assigned

Labels

benchmark Run benchmarks on PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amontoison @gdalle