Skip to content

Add a compat entry for CUDA.jl in test/Project.toml#293

Merged
amontoison merged 2 commits intomainfrom
amontoison-patch-1
Jan 4, 2026
Merged

Add a compat entry for CUDA.jl in test/Project.toml#293
amontoison merged 2 commits intomainfrom
amontoison-patch-1

Conversation

@amontoison
Copy link
Copy Markdown
Collaborator

@amontoison amontoison commented Jan 4, 2026

Temporary solution for #292

@amontoison amontoison changed the title Add a compat for CUDA.jl in test/Project.toml Add a compat entry for CUDA.jl in test/Project.toml Jan 4, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (662df63) to head (7e48573).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #293   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         2016      2016           
=========================================
  Hits          2016      2016           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amontoison amontoison merged commit a5f32f1 into main Jan 4, 2026
11 checks passed
@amontoison amontoison deleted the amontoison-patch-1 branch January 4, 2026 21:20
@gdalle
Copy link
Copy Markdown
Member

gdalle commented Jan 4, 2026

This is not a good idea, since many packages have SMC as an indirect dependency. I'd rather have our decompression be broken on GPU (no one uses it anyway) than hold back half of the ecosystem to an older version of CUDA. This should be fixed in the CUDA repo anyway, and in the meantime, I suggest we revert this PR

@amontoison
Copy link
Copy Markdown
Collaborator Author

amontoison commented Jan 4, 2026

@gdalle It is only a compat entry in the Project.toml of the tests.
Can you explain how it could hold back the ecosystem?

@amontoison
Copy link
Copy Markdown
Collaborator Author

I fixed it such that I don't break it with other modifications in SMC.jl.
I think it is still relevant to keep the tests working (if it doesn't hold back the ecosystem).

@gdalle
Copy link
Copy Markdown
Member

gdalle commented Jan 4, 2026

Oh sorry I missed the fact that it was specific to tests. Disregard anything I said ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants