Conversation
This was
linked to
issues
Aug 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
- Coverage 99.83% 98.37% -1.47%
==========================================
Files 11 10 -1
Lines 605 614 +9
==========================================
Hits 604 604
- Misses 1 10 +9 ☔ View full report in Codecov by Sentry. |
amontoison
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source
NonSymmetricColoringResult,StarSetColoringResultandTreeSetColoringResult, plus the uglyLinearSystemColoringResult.S isa SparseMatrixCSC(fix MakeS::SparseMatrixCSC{Bool,Int}#69) and put the necessary information for allocation-less decompression into dense and sparseA. The complexity is now mainly in the constructors for these result types.decompression_eltypekeyword argument tocoloring(fix Provideeltypeof decompression targetA#44). Use it inside theTreeSetColoringResultconstructor to initializestored_values.decompressiontype parameter from theColoringProblemto theGreedyColoringAlgorithm(fix Should the decompression method go in theColoringProblemor in theColoringAlgorithm? #66).:symmetricstructures require a:columnpartition (fix Add more methods for coloring? #51).Tests
SparseMatrixCSCfor now).LinearSystemColoringResultin addition to the native result