Migrate to stream-ordered allocator for arrays#422
Migrate to stream-ordered allocator for arrays#422pxl-th wants to merge 6 commits intopxl-th/waitfrom
Conversation
|
I am wondering if this PR would also fix the synchronization issue in #298 |
|
In general this PR fixes use-after-free issues, where previously one could hit a scenario where:
But the issue with HIP-based allocations at the moment is that they are drawn from a HIP memory pool which grows on-demand and you can limit the total size of the pool only starting from ROCm 5.5+ via And when the pool grows to near 100% of the total memory available on the device (because GC is not keeping up) it kills our HSA queue since it cannot allocate necessary resources for a kernel dispatch. Interestingly, you can get the memory limit of the pool on ROCm 5.4 but not set it. And constraining pool growth from the Julia side seems unreliable at the moment. |
|
Superseded by #423 |
TODO: add detailed PR description
Builds upon #419
Fixes #418