Merged
Conversation
(cherry picked from commit 62cf82d)
(cherry picked from commit ed48276)
(cherry picked from commit fbf4f60)
(cherry picked from commit 59894d3)
(cherry picked from commit 1fe5a41)
(cherry picked from commit 95727ae)
(cherry picked from commit 1a5b421)
(cherry picked from commit 6ee90d3)
(cherry picked from commit 16f977b)
(cherry picked from commit ef683ab)
(cherry picked from commit b416bc4)
(cherry picked from commit b5b7ade)
(cherry picked from commit c7cc616)
(cherry picked from commit 41d2d41)
(cherry picked from commit 68d0c37)
(cherry picked from commit e26be82)
(cherry picked from commit ecd9e8a)
(cherry picked from commit b62e265)
(cherry picked from commit 7355b83)
(cherry picked from commit 75b94bc)
(cherry picked from commit 09ea684)
(cherry picked from commit 9237b9c)
(cherry picked from commit 39433e1)
(cherry picked from commit 2f520ea)
(cherry picked from commit 07a603e)
(cherry picked from commit cfba911)
(cherry picked from commit 713f5ac)
(cherry picked from commit 7c69861)
(cherry picked from commit 15fd0a7)
(cherry picked from commit b327ce7)
(cherry picked from commit 05419e6)
(cherry picked from commit 4c52aab)
(cherry picked from commit 37ce8a6)
(cherry picked from commit fbf4f60)
(cherry picked from commit ef683ab)
(cherry picked from commit 75b94bc)
pxl-th
force-pushed
the
pxl-th/rocsparse
branch
from
5a0c0d0 to
cd817a1
Compare
Member
Author
|
Let's merge it to have some initial support, and implement |
Contributor
|
@pxl-th @jpsamaroo I'd never thought I'd see the day :D. Thanks for working hard to merge this. |
Member
Author
Thank you for putting a PR in the first place! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #298.
Main differences from #298:
generic.jltests (init with zero dense arrays used for storingmv!output).Note: certain operations, like broadcasting two rocsparse arrays require
accumulate!kernel, which AMDGPU does not yet have (it performs scalar indexing instead). Disabled respective tests until we have it implemented.CC: @matinraayai