Skip to content

using CPU as default for Scratchpad and SharedMemory#300

Merged
vchuravy merged 2 commits intoJuliaGPU:masterfrom
leios:cpu_fixes
May 25, 2022
Merged

using CPU as default for Scratchpad and SharedMemory#300
vchuravy merged 2 commits intoJuliaGPU:masterfrom
leios:cpu_fixes

Conversation

@leios
Copy link
Contributor

@leios leios commented May 25, 2022

I have been getting this error ever since #288

[ Info: Precompiling KernelAbstractions [63c18a36-062a-441e-b654-da1e3ab1ce7c]
WARNING: Method definition SharedMemory(Type{T}, Base.Val{Dims}, Base.Val{x} where x) where {T, Dims} in module KernelAbstractions at /home/leios/projects/KernelAbstractions.jl/src/KernelAbstractions.jl:464 overwritten at /home/leios/projects/KernelAbstractions.jl/src/cpu.jl:204.
  ** incremental compilation may be fatally broken for this module **

WARNING: Method definition Scratchpad(Any, Type{T}, Base.Val{Dims}) where {T, Dims} in module KernelAbstractions at /home/leios/projects/KernelAbstractions.jl/src/KernelAbstractions.jl:460 overwritten at /home/leios/projects/KernelAbstractions.jl/src/cpu.jl:218.
  ** incremental compilation may be fatally broken for this module **

I think it's because there used to be an overdub for ScratchPad and SharedMemory on the CPU with a default to an error message in KernelAbstractions, but now we are using @device_override and using the CPU versions as defaults.

This PR just moves the stuff in cpu.jl to KernelAbstractions.jl. There might be a better solution, so it's up to you what you want to do.

@leios leios marked this pull request as ready for review May 25, 2022 10:37
@vchuravy
Copy link
Member

Thanks! That's a silly oversight of me

@vchuravy vchuravy merged commit 3d0902d into JuliaGPU:master May 25, 2022
@leios leios deleted the cpu_fixes branch May 25, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants