using CPU as default for Scratchpad and SharedMemory#300
Merged
vchuravy merged 2 commits intoJuliaGPU:masterfrom May 25, 2022
Merged
using CPU as default for Scratchpad and SharedMemory#300vchuravy merged 2 commits intoJuliaGPU:masterfrom
vchuravy merged 2 commits intoJuliaGPU:masterfrom
Conversation
vchuravy
reviewed
May 25, 2022
Member
|
Thanks! That's a silly oversight of me |
vchuravy
approved these changes
May 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been getting this error ever since #288
I think it's because there used to be an overdub for ScratchPad and SharedMemory on the CPU with a default to an error message in KernelAbstractions, but now we are using
@device_overrideand using the CPU versions as defaults.This PR just moves the stuff in
cpu.jltoKernelAbstractions.jl. There might be a better solution, so it's up to you what you want to do.