Conversation
vchuravy
commented
Aug 3, 2022
vchuravy
commented
Aug 3, 2022
vchuravy
commented
Aug 3, 2022
vchuravy
commented
Aug 3, 2022
vchuravy
commented
Aug 3, 2022
vchuravy
commented
Aug 3, 2022
vchuravy
commented
Aug 3, 2022
vchuravy
commented
Aug 3, 2022
vchuravy
commented
Aug 3, 2022
vchuravy
commented
Aug 4, 2022
vchuravy
commented
Aug 4, 2022
vchuravy
commented
Aug 4, 2022
lcw
reviewed
Aug 5, 2022
lib/CUDAKernels/src/CUDAKernels.jl
Outdated
| end | ||
|
|
||
| function KernelAbstractions.async_copy!(::CUDADevice, A, B; dependencies=nothing, progress=yield) | ||
| function KernelAbstractions.async_copy!(::CUDADevice, A, B, progress=yield) |
Collaborator
There was a problem hiding this comment.
Is the progress argument still needed?
vchuravy
force-pushed
the
vc/nix_dependencies
branch
from
95477e1 to
fac1a9c
Compare
Open
Contributor
|
We recently had a discussion about using KernelAbstractions in GPUArrays. To do this, we need to:
|
vchuravy
force-pushed
the
vc/nix_dependencies
branch
from
fac1a9c to
937da29
Compare
This was referenced Feb 1, 2023
vchuravy
force-pushed
the
vc/nix_dependencies
branch
from
937da29 to
0f00358
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I have mentioned over the last little while I would like to remove the event
system. Over the years it has proven itself to be cumbersome, and prone to introduce
bugs.
In contrast @maleadt developed a task-based concurrency scheme for CUDA.jl that is rather
elegant and doesn't introduce a new terminology beside Julia's existing tasks.
This is the last big chance I forsee and I plan on KernelAbstractions 0.9 to be a direct
pre-cursor to 1.0.
Things that need to be hammered out:
synchronize(::Device)is rather nice, but is also exported by CUDA.jl