Skip to content

[oneMKL] Fix gesvd! #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amontoison merged 3 commits into from
Dec 3, 2024
Merged

[oneMKL] Fix gesvd! #485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f775f40
[oneMKL] Fix gesvd!
amontoison Dec 2, 2024
165a0be
Fix a typo
amontoison Dec 2, 2024
9dd54b7
Use ZE_NULL
amontoison Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions lib/mkl/wrappers_lapack.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,30 +304,31 @@ for (bname, fname, elty, relty) in ((:onemklSgesvd_scratchpad_size, :onemklSgesv
jobvt::Char,
A::oneStridedMatrix{$elty})
m, n = size(A)
k = min(m, n)
lda = max(1, stride(A, 2))

U = if jobu === 'A'
oneMatrix{$elty}(undef, m, m)
elseif jobu == 'S' || jobu === 'O'
oneMatrix{$elty}(undef, m, min(m, n))
elseif jobu === 'N'
oneMatrix{$elty}(undef, 0, 0) # Equivalence of CU_NULL?
elseif jobu === 'S'
oneMatrix{$elty}(undef, m, k)
elseif jobu === 'N' || jobu === 'O'
ZE_NULL
else
error("jobu must be one of 'A', 'S', 'O', or 'N'")
end
ldu = U == oneMatrix{$elty}(undef, 0, 0) ? 1 : max(1, stride(U, 2))
S = oneVector{$relty}(undef, min(m, n))
ldu = U == ZE_NULL ? 1 : max(1, stride(U, 2))
S = oneVector{$relty}(undef, k)

Vt = if jobvt === 'A'
oneMatrix{$elty}(undef, n, n)
elseif jobvt === 'S' || jobvt === 'O'
oneMatrix{$elty}(undef, min(m, n), n)
elseif jobvt === 'N'
oneMatrix{$elty}(undef, 0, 0)
elseif jobvt === 'S'
oneMatrix{$elty}(undef, k, n)
elseif jobvt === 'N' || jobvt === 'O'
ZE_NULL
else
error("jobvt must be one of 'A', 'S', 'O', or 'N'")
end
ldvt = Vt == oneArray{$elty}(undef, 0, 0) ? 1 : max(1, stride(Vt, 2))
ldvt = Vt == ZE_NULL ? 1 : max(1, stride(Vt, 2))

queue = global_queue(context(A), device())
scratchpad_size = $bname(sycl_queue(queue), jobu, jobvt, m, n, lda, ldu, ldvt)
Expand Down
10 changes: 10 additions & 0 deletions test/onemkl.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1421,6 +1421,16 @@ end
d_A = oneMatrix(A)
U, Σ, Vt = oneMKL.gesvd!('A', 'A', d_A)
@test A ≈ collect(U[:,1:n] * Diagonal(Σ) * Vt)

for jobu in ('A', 'S', 'N', 'O')
for jobvt in ('A', 'S', 'N', 'O')
(jobu == 'A') && (jobvt == 'A') && continue
(jobu == 'O') && (jobvt == 'O') && continue
d_A = oneMatrix(A)
U2, Σ2, Vt2 = oneMKL.gesvd!(jobu, jobvt, d_A)
@test Σ ≈ Σ2
end
end
end

@testset "syevd! -- heevd!" begin
Expand Down