Skip to content

Cancel previous running workflows on push#292

Merged
devmotion merged 1 commit intomasterfrom
dw/cancel
Jun 1, 2021
Merged

Cancel previous running workflows on push#292
devmotion merged 1 commit intomasterfrom
dw/cancel

Conversation

@devmotion
Copy link
Member

Just learnt about https://github.com/styfle/cancel-workflow-action from JuliaDiff/ChainRules.jl#426. Seems this could solve #281.

I followed the instructions in https://github.com/styfle/cancel-workflow-action#advanced-pull-requests-from-forks which should also work for PRs from forks.

@mzgubic
Copy link

mzgubic commented Jun 1, 2021

It doesn't seem like it ran, did it?

@devmotion
Copy link
Member Author

IIRC this type of actions always uses the version on master for security reasons. It doesn't exist currently so it's not run.

@devmotion
Copy link
Member Author

It is mentioned in the documentation:

Note: This event will only trigger a workflow run if the workflow file is on the default branch.

@devmotion
Copy link
Member Author

Of course, this makes it difficult to assess if the action works properly here 😄

@willtebbutt @theogf What do you think, should we just try it and see if it works and possibly fix it in follow-up PRs?

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's do it, 🤞

@theogf
Copy link
Member

theogf commented Jun 1, 2021

Go for it!

@devmotion devmotion merged commit 75b0d25 into master Jun 1, 2021
@devmotion devmotion deleted the dw/cancel branch June 1, 2021 20:53
@devmotion
Copy link
Member Author

It seems to be at least somewhat correct and working: https://github.com/JuliaGaussianProcesses/KernelFunctions.jl/actions/runs/897590843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants