Skip to content

Conversation

@simonschoelly
Copy link
Member

This PR does some cosmetic changes and fixes a bug in spectral_layout where the largest eigenvalues instead of the smallest positive of the laplacian matrix where used.

@simonschoelly
Copy link
Member Author

Apparently, we have to wait until a new version of LightGraphs gets tagged, then this PR should work.

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #80 into master will increase coverage by 2.45%.
The diff coverage is 63.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage    25.8%   28.26%   +2.45%     
==========================================
  Files           9        9              
  Lines         496      467      -29     
==========================================
+ Hits          128      132       +4     
+ Misses        368      335      -33
Impacted Files Coverage Δ
src/collapse_plot.jl 0% <0%> (ø) ⬆️
src/stress.jl 0% <0%> (ø) ⬆️
src/layout.jl 46.83% <76%> (+5.06%) ⬆️
src/plot.jl 55.69% <0%> (+4.53%) ⬆️
src/lines.jl 37.87% <0%> (+5.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f73a3...1027506. Read the comment docs.

@simonschoelly simonschoelly merged commit 6458908 into JuliaGraphs:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant