Skip to content

Conversation

@matbesancon
Copy link
Member

No description provided.

@simonschoelly
Copy link
Member

If this is a problem with the .travis file, maybe we should copy what we have in LightGraphs

@matbesancon
Copy link
Member Author

I fixed it this should do

@simonschoelly
Copy link
Member

Still not working, maybe we remove the part in script: from travis, then the default script should get used.

@codecov
Copy link

codecov bot commented Apr 22, 2019

Codecov Report

Merging #86 into master will decrease coverage by 0.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #86      +/-   ##
=========================================
- Coverage    26.2%   25.8%   -0.41%     
=========================================
  Files           9       9              
  Lines         496     496              
=========================================
- Hits          130     128       -2     
- Misses        366     368       +2
Impacted Files Coverage Δ
src/layout.jl 41.77% <0%> (-1.27%) ⬇️
src/plot.jl 51.16% <0%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6b2d14...6c54003. Read the comment docs.

@simonschoelly
Copy link
Member

Should we add a [compat] section? We have some requirements in REQUIREMENTS, so maybe we should also have them here.

See https://julialang.github.io/Pkg.jl/dev/compatibility/

@matbesancon
Copy link
Member Author

yup good point

@simonschoelly simonschoelly merged commit 23f73a3 into JuliaGraphs:master Apr 22, 2019
@simonschoelly
Copy link
Member

Now we have to figure out how to tell Registrator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants