Skip to content

replace bad threadid buffering#266

Merged
IanButterworth merged 1 commit intomasterfrom
ib/task_local
Aug 9, 2023
Merged

replace bad threadid buffering#266
IanButterworth merged 1 commit intomasterfrom
ib/task_local

Conversation

@IanButterworth
Copy link
Copy Markdown
Member

Fixes #265

This is a naive swap out. There may be refactoring that should happen at a higher level with the buffer management.

Untested locally.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (afd33f4) 94.23% compared to head (4dc70a1) 94.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   94.23%   94.25%   +0.02%     
==========================================
  Files          13       13              
  Lines        1699     1706       +7     
==========================================
+ Hits         1601     1608       +7     
  Misses         98       98              
Files Changed Coverage Δ
src/imfilter.jl 96.62% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks fine to me!

@IanButterworth IanButterworth merged commit fcd0af6 into master Aug 9, 2023
@IanButterworth IanButterworth deleted the ib/task_local branch August 9, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect usage of threadid

2 participants