drop obsolete imports, remark unbroken test#55
Merged
Evizero merged 2 commits intoJuliaImages:masterfrom Aug 19, 2018
RalphAS:ras/bump1.0a
Merged
drop obsolete imports, remark unbroken test#55Evizero merged 2 commits intoJuliaImages:masterfrom RalphAS:ras/bump1.0a
Evizero merged 2 commits intoJuliaImages:masterfrom
RalphAS:ras/bump1.0a
Conversation
This also lets us see what currently blocks testing on CI
Evizero
reviewed
Aug 19, 2018
| etp = @inferred ImageTransformations.box_extrapolation(img) | ||
| @test @inferred(ImageTransformations.box_extrapolation(etp)) === etp | ||
| @test_broken summary(etp) == "2×2 extrapolate(interpolate(::Array{Gray{N0f8},2}, BSpline(Linear()), OnGrid()), Gray{N0f8}(0.0)) with element type $(ctqual)Gray{$(fpqual)Normed{UInt8,8}}" | ||
| @test summary(etp) == "2×2 extrapolate(interpolate(::Array{Gray{N0f8},2}, BSpline(Linear()), OnGrid()), Gray{N0f8}(0.0)) with element type $(ctqual)Gray{$(fpqual)Normed{UInt8,8}}" |
Member
There was a problem hiding this comment.
isn't this still broken until JuliaMath/Interpolations.jl#226 is merged?
Member
There was a problem hiding this comment.
Working on it now. Hoping to have it finished by tomorrow.
Contributor
Author
There was a problem hiding this comment.
Your'e right, I was testing with the showarg fixes in place. I'll set this to "skipped" like the others for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also lets us see what currently blocks testing on CI