Skip to content

JOcTree Reorganization#6

Merged
lruthotto merged 8 commits intoJuliaInv:masterfrom
dwfmarchant:Reoganization
Mar 21, 2017
Merged

JOcTree Reorganization#6
lruthotto merged 8 commits intoJuliaInv:masterfrom
dwfmarchant:Reoganization

Conversation

@dwfmarchant
Copy link
Copy Markdown
Member

Ok, I started implementing some of the things we talked about this morning:

  • Moved the plotting code to JinvVis
  • Removed the FEM code
  • Deleted create mesh codes that don't work any more (and weren't being included)
  • Consolidated numbering functions to one file.
  • Consolidated getGrid functions to one file.
  • Moved mesh creation codes to separate folder.
  • Rearranged JOcTree.jl so it is a bit easier to read.

There are a few things I think we should still do here:

  • createOcTreeFromPoints & createOcTreeFromTopo aren't included in JOcTree.jl and I don't think they've been updated. These look useful and they should get cleaned up.
  • getLineIntegrationMatrix isn't included in JOcTree.jl and isn't used anywhere. Is this still needed?

@dwfmarchant
Copy link
Copy Markdown
Member Author

I've also added the codes to read and write UBC format octree files - these were in MaxwellUtils.

@lruthotto
Copy link
Copy Markdown
Contributor

Shall we merge this or is this still under active development? Without any tests it's difficult to get an overview here.

@dwfmarchant
Copy link
Copy Markdown
Member Author

Unless there's anything else that we should combine I think we can merge it.

@lruthotto lruthotto merged commit 4e0d978 into JuliaInv:master Mar 21, 2017
@Pbellive Pbellive mentioned this pull request Mar 22, 2017
29 tasks
@dwfmarchant dwfmarchant deleted the Reoganization branch March 22, 2017 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants