JOcTree Reorganization#6
Merged
lruthotto merged 8 commits intoJuliaInv:masterfrom Mar 21, 2017
dwfmarchant:Reoganization
Merged
JOcTree Reorganization#6lruthotto merged 8 commits intoJuliaInv:masterfrom dwfmarchant:Reoganization
lruthotto merged 8 commits intoJuliaInv:masterfrom
dwfmarchant:Reoganization
Conversation
…) method for consistency.
Member
Author
|
I've also added the codes to read and write UBC format octree files - these were in MaxwellUtils. |
Contributor
|
Shall we merge this or is this still under active development? Without any tests it's difficult to get an overview here. |
Member
Author
|
Unless there's anything else that we should combine I think we can merge it. |
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, I started implementing some of the things we talked about this morning:
There are a few things I think we should still do here: