refactor: extract MIME utilities into modules/message-utils.js#193
Open
JuliaKalder wants to merge 1 commit into
Open
refactor: extract MIME utilities into modules/message-utils.js#193JuliaKalder wants to merge 1 commit into
JuliaKalder wants to merge 1 commit into
Conversation
….js (#74) Move two pure MIME utility functions out of the background.js orchestration layer into a dedicated module with named exports, and add unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findPartandextractBodyout ofbackground.jsinto a newmodules/message-utils.jsmodule as named exportsbackground.jsto import them from the new moduletests/message-utils.test.jswith 11 unit tests covering both functions (all passing)Verification steps
npm test— all 11 new tests pass; pre-existing failures intemplate-store.test.jsare unrelated to this changebackground.jsno longer contains inline definitions offindPartorextractBodyFixes #74