refactor: deduplicate populateCategoryFilter into shared module#194
Open
JuliaKalder wants to merge 1 commit into
Open
refactor: deduplicate populateCategoryFilter into shared module#194JuliaKalder wants to merge 1 commit into
JuliaKalder wants to merge 1 commit into
Conversation
Extract the duplicated DOM manipulation (clearing and repopulating a <select> filter) into modules/ui-helpers.js as setFilterOptions(). - options/options.js: populateCategoryFilter() is now a one-liner that delegates DOM work to setFilterOptions() - popup/popup.js: identity-aware variant likewise delegates its DOM work to setFilterOptions(); also removes the now-unused getCategories import that was left over from an earlier version of the function Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<select>DOM-manipulation pattern (clear old options, append new ones) intomodules/ui-helpers.jsassetFilterOptions(filterId, categories)options/options.js:populateCategoryFilter()is now a one-liner delegating to the shared helperpopup/popup.js: identity-aware variant also delegates its DOM work to the shared helper; removed the stale unusedgetCategoriesimport that was left over from a previous version of that functionVerification
node --test tests/*.test.js: 90 pass / 7 fail — the 7 failures are pre-existing onmain(all inmigrateV0toV1intemplate-store.test.js) and are not introduced by this changeoptions/options.jsand the single call-site inpopup/popup.jsuse the samepopulateCategoryFilter()signature as before — no callers needed updatingFixes #78
🤖 Generated with Claude Code