refactor: extract populateEditorFields to eliminate duplicated form setup#195
Open
JuliaKalder wants to merge 1 commit into
Open
refactor: extract populateEditorFields to eliminate duplicated form setup#195JuliaKalder wants to merge 1 commit into
JuliaKalder wants to merge 1 commit into
Conversation
…licateTemplate (#79) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
populateEditorFields(template)helper inoptions/options.js(after the module-level variable declarations), handling both a template object andnullfor blank formsopenEditor(when editing an existing template) now callspopulateEditorFields(template)instead of duplicating 20+ lines of form-setup codeduplicateTemplatenow callspopulateEditorFields(template)then overridesnameInput.valuewith the i18n-prefixed duplicate name (the only intentional difference between the two callers)pendingAttachmentspre-assignment induplicateTemplate(the helper sets it)migrateV0toV1failures are unrelated to this changeVerification
npm test: 90 pass / 7 fail (same 7 pre-existing failures intemplate-store.test.js::migrateV0toV1, unrelated to options.js)Fixes #79
🤖 Generated with Claude Code