refactor: move duplicate-name enforcement from UI layer to saveTemplate#197
Open
JuliaKalder wants to merge 1 commit into
Open
refactor: move duplicate-name enforcement from UI layer to saveTemplate#197JuliaKalder wants to merge 1 commit into
JuliaKalder wants to merge 1 commit into
Conversation
Move the duplicate-name check from the UI layer (options.js) to the data layer (template-store.js) so no direct caller of saveTemplate can bypass it. The check is case-insensitive and throws with err.code = "DUPLICATE_NAME". The options.js handleSave now catches that error to show the same inline validation message as before. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
saveTemplateinmodules/template-store.js; throws an error witherr.code = "DUPLICATE_NAME"when a conflict is detected, so no direct caller can bypass the uniqueness rulehandleSaveinoptions/options.jsand replaces it with a catch onDUPLICATE_NAME, showing the same inline validation error as beforetests/template-store.test.jscovering: new template with duplicate name, update to another template's name, keeping own name on update, and case-insensitivityVerification
All new tests pass. The 7 pre-existing
migrateV0toV1failures are unrelated to this change (they test the input array instead of the returnedtemplatesproperty from.map()).Fixes #85