refactor: separate concerns in insertTemplateIntoTab#199
Open
JuliaKalder wants to merge 1 commit into
Open
Conversation
…nsert.js (#61) - The dynamic import() of template-store.js that previously existed inside insertTemplateIntoTab has already been replaced by a static top-level import; this commit confirms and preserves that separation. - Extract the base64-decode + messenger.compose.addAttachment loop into a new, separately exported async function decodeAndAttach(tabId, attachments). This isolates infrastructure/attachment concerns from the domain logic in insertTemplateIntoTab, making each function independently testable. - No behaviour change; all callers continue to work unchanged. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import()with static top-level import oftemplate-store.js(already present at the module top; this refactor confirms and locks that separation)decodeAndAttach(tabId, attachments)as a separately exported async function, isolating the base64 decode +messenger.compose.addAttachmentloop from domain logic ininsertTemplateIntoTabbackground.js,popup/popup.js) continue to work unchangedVerification
npm testpasses; the 7 pre-existing failures inmigrateV0toV1are unrelated to this changedecodeAndAttachis now independently importable and testableFixes #61