refactor: extract getIdentities() to separate data fetch from DOM rendering#204
Open
JuliaKalder wants to merge 1 commit into
Open
refactor: extract getIdentities() to separate data fetch from DOM rendering#204JuliaKalder wants to merge 1 commit into
JuliaKalder wants to merge 1 commit into
Conversation
…dering (#119) Add getIdentities() pure data function to modules/template-store.js so that identity label-formatting logic is unit-testable in isolation. loadIdentities() in options.js is now a thin DOM-only wrapper that delegates data retrieval to getIdentities(), following the same pattern established by getTemplates(). Fixes #119
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getIdentities()pure data function tomodules/template-store.js, following the same pattern asgetTemplates()loadIdentities()inoptions/options.jsis now a thin DOM-only wrapper that callsgetIdentities()and iterates over the returned objectsidentity.name ? ... : identity.email) now lives in the module layer where it is unit-testable without a DOM ormessenger.*environmentVerification
migrateV0toV1test failures unrelated to this change (verified by running tests against the original code onmain)Fixes #119