-
-
Notifications
You must be signed in to change notification settings - Fork 53
Dimension check too restrictive in copytrito! and lacpy! #1074
Copy link
Copy link
Closed
JuliaLang/julia
#54587Description
In JuliaLang/julia#51909, I interfaced copytri! and lacpy!, but I didn't test them on rectangular matrices. The check:
(m1 < m || n1 < n) && throw(DimensionMismatch(lazy"B of size ($m1,$n1) should have at least the same number of rows and columns as A of size ($m,$n)"))is too restrictive in two cases.
-
If
Ahas more rows than columns anduplo = 'U',Bonly needs to bep x p, wherepis the number of columns ofA. A common application of this is performing a reduced QR onA. -
Similarly, if
Ahas more columns than rows anduplo = 'L',Bonly needs to bet x t, wheretis the number of rows ofA. This is relevant when performing a reduced LQ onA.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels