make dot docstring match the implementation#1400
Open
adienes wants to merge 1 commit intoJuliaLang:masterfrom
Open
make dot docstring match the implementation#1400adienes wants to merge 1 commit intoJuliaLang:masterfrom
dot docstring match the implementation#1400adienes wants to merge 1 commit intoJuliaLang:masterfrom
Conversation
Member
|
Should we instead fix the code to match the docstring? |
Member
Author
|
I suppose that depends on whether you think of dot more as a reducing operation or a "scalar" operation on scalars-that-are-actually-vectors, in that reducing operations typically widen types and arithmetic does not. note that numpy also chooses to overflow on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as written it's incorrect since
sumwill promote the types but+(anddot) overflowcloses #1453