Open
Conversation
stevengj
commented
Mar 19, 2026
| ``` | ||
| """ | ||
| schur(A::AbstractMatrix{T}) where {T} = schur!(copy_similar(A, eigtype(T))) | ||
| schur(A::UpperHessenberg{T}) where {T} = schur!(copy_similar(A, eigtype(T))) |
Member
Author
There was a problem hiding this comment.
It's not clear to me why this schur(A::UpperHessenberg{T}) method was added in the first place — it seems redundant with schur(A::AbstractMatrix{T})?
stevengj
commented
Mar 19, 2026
stevengj
commented
Mar 20, 2026
stevengj
commented
Mar 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1565 +/- ##
==========================================
- Coverage 94.35% 94.32% -0.03%
==========================================
Files 35 35
Lines 16004 16004
==========================================
- Hits 15100 15096 -4
- Misses 904 908 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
araujoms
reviewed
Mar 25, 2026
Co-authored-by: Mateus Araújo <maltusan@gmail.com>
araujoms
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an apparent bug in JuliaLang/julia#47872 —
schur(A::UpperHessenberg{T})calledcopy_similar(A, eigtype(T)))but thecopy_similarfunction strips away theUpperHessenbergwrapper. As a result, the optimizedschur!function was not being called.Following #1557, this changes it to call
eigencopy_oftype, which preserves theUpperHessenbergwrapper (and alsoHermitianwrappers, butschuralready has a specialized dispatch for Hermitian cases). It also adds a fallbackschur!for non-BLAS types, to avoid breaking anything.cc @albertomercurio, @Jutho, and @dkarrasch, who were involved in the original PR.