fix invalidations when loading ForwardDiff.jl and ChainRulesCore.jl#47091
Merged
KristofferC merged 1 commit intoJuliaLang:masterfrom Oct 10, 2022
Merged
Conversation
KristofferC
pushed a commit
that referenced
this pull request
Oct 27, 2022
(cherry picked from commit 0dada17)
37 tasks
KristofferC
pushed a commit
that referenced
this pull request
Oct 28, 2022
(cherry picked from commit 0dada17)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I improved type stability to fix some invalidations. This is based on the following code (executed with a local build using the
backports-release-1.8branch):With this PR on top of the current
backports-release-1.8branch:Most of the remaining invalidations could be fixed around
sort_int_range!. However, this part changed quite a bit onmaster, so I'm not sure whether it's better to wait until v1.9 is released to revisit this issue.Edit: It's nice to observe that this fixes JuliaDiff/ChainRulesCore.jl#576:
(with this PR on top of the current
backports-release-1.8branch).