Hotfix some direct solve ambiguities#181
Open
termi-official wants to merge 7 commits intoJuliaLinearAlgebra:masterfrom
Open
Hotfix some direct solve ambiguities#181termi-official wants to merge 7 commits intoJuliaLinearAlgebra:masterfrom
termi-official wants to merge 7 commits intoJuliaLinearAlgebra:masterfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #181 +/- ##
==========================================
- Coverage 87.47% 0.00% -87.48%
==========================================
Files 11 11
Lines 1812 1712 -100
==========================================
- Hits 1585 0 -1585
- Misses 227 1712 +1485
☔ View full report in Codecov by Sentry. |
Author
|
I am still lost why only the WY form has issues, but this PR should fix it. Plus it fixes ambiguities with some sparse direct solve dispatches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix as proposed in JuliaArrays/BlockArrays.jl#319