Expand stirlings1 and stirlings2 to work with very large integers#84
Closed
wherrera10 wants to merge 2 commits intoJuliaMath:masterfrom
wherrera10:master
Closed
Expand stirlings1 and stirlings2 to work with very large integers#84wherrera10 wants to merge 2 commits intoJuliaMath:masterfrom wherrera10:master
wherrera10 wants to merge 2 commits intoJuliaMath:masterfrom
wherrera10:master
Conversation
The functions stirlings1(n, k) and stirlings1(n, k) are currently (mid 2019) written to specify Int arguments for n and k, but the documentation states that they should optionally take a BigInt as well. This can be fixed by changing them not to specify an Int for n and k.
wherrera10
changed the title
mschauer
pushed a commit
that referenced
this pull request
Nov 11, 2022
> The documentation for stirlings1 and stirlings2 indicates that they can use BigInts if provided with such as argument. However the existing functions specify n and k arguments to be Int. This patch allows support for BigInt integers without breaking type consistency of return types, and also provides for some memoization, since otherwise the functions, since they are recursive, can be slow when handling very large integers. (credit https://github.com/wherrera10)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #84 +/- ##
===========================================
+ Coverage 75.51% 94.40% +18.89%
===========================================
Files 7 7
Lines 637 518 -119
===========================================
+ Hits 481 489 +8
+ Misses 156 29 -127 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation for stirlings1 and stirlings2 indicates that they can use BigInts if provided with such as argument. However the existing functions specify n and k arguments to be Int. This patch allows support for BigInt integers without breaking type consistency of return types, and also provides for some memoization, since otherwise the functions, since they are recursive, can be slow when handling very large integers.