Conversation
Member
Author
|
I ended up reverting this to the more conservative infinity norm again, because in #32 I found cases where the L1 norm was too aggressive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following chebfun, to check whether to drop coefficients$c_k$ , use $|c_k| < \Vert c \Vert_1 \times \text{droptol}$ rather than $\Vert c \Vert_{\infty}$ . This makes sense because the value of the function is bounded by the L1 norm (since each Chebyshev polynomial takes on values bounded by ±1).
It allows the
droptolto be a little more aggressive about shrinking the polynomial degree.