Correct bugs in the b-spline's hessian calculation (fixes #180)#181
Closed
jeff-regier wants to merge 1 commit intoJuliaMath:masterfrom
jeff-regier:hessian_bug
Closed
Correct bugs in the b-spline's hessian calculation (fixes #180)#181jeff-regier wants to merge 1 commit intoJuliaMath:masterfrom jeff-regier:hessian_bug
jeff-regier wants to merge 1 commit intoJuliaMath:masterfrom
jeff-regier:hessian_bug
Conversation
Author
|
Ah, so this PR fixes the obvious syntax errors, but I don't think the Hessians are correct :-( |
Member
|
#122. Sadly, someone who uses hessians needs to sit down and work out the math again. |
This was referenced Aug 13, 2018
Merged
Member
|
Superseded by #226 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are a couple of changes that get
hessianworking again for b-splines.