Merged
Conversation
Member
|
We could move InvariantEnsembles.jl into a separate (unregistered for now) package. |
Contributor
Author
|
Is this something that should be done in this PR? |
Member
|
No should be fine, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
RandomMatrices.jlpass the tests on v1.0 (although not all of the code is covered)There are some issues:
ApproxFun.jlwas installed and only then included the filesrc/InvariantEnsembles.jl. This is not possible anymore, so I replaced that functionality with one that loads this file whenever the user callsusing ApproxFun. This is done using the packageRequires.jltest/Haar.jlcall some code that seems to be broken. Previously these tests never got triggered, because they where inside some if-block that was not executed. I now changed these tests to@test_brokenbut that does not change the fact that the functionexpectationinsrc/Haar.jlseems to be broken.