Change compat for ForwardDiff -- upper bound DiffRules#40225
Merged
DilumAluthge merged 1 commit intoJuliaRegistries:masterfrom Jul 4, 2021
Merged
Change compat for ForwardDiff -- upper bound DiffRules#40225DilumAluthge merged 1 commit intoJuliaRegistries:masterfrom
DilumAluthge merged 1 commit intoJuliaRegistries:masterfrom
Conversation
Contributor
Author
|
Did I get this right? When I try installing on a fresh environment, I seem to get DiffRules v1.2.1 which is outside "1-1.02". Any chance that ought to read "1.0-1.02" or something? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an upper bound so that all existing versions of ForwardDiff will not use DiffRules 1.1, and stop at 1.02. This applies to ForwardDiff v0.10.8 to v0.10.18 (latest).
The reason to do so is that DiffRules supports N-ary rules, but ForwardDiff throws an error if given one, and DiffRules v1.1 added a few. This isn't even a new export from DiffRules, it's a documented feature, although the package contained no rules using it. That makes me think it's not a breaking change to DiffRules, but just a bug in some versions of ForwardDiff. So the aim of this PR is to prevent them from installing a version which triggers that.
(The immediate fix is that JuliaDiff/DiffRules.jl#60 and DiffRules 1.2.1 has removed these rules, temporarily. So installing the latest should not at present break things.)