Merged
Conversation
This is type-piracy, but we cannot change that (until JuliaLang/julia#2326), so at least do not make these method intersections unnecessary slow and complicated for everyone who does not care about SparseArrays and does not load it, and unreliable for everyone who does load it.
Contributor
Author
|
bump |
Member
|
Does this need to get merged and backported to 1.9? cc @Wimmerer @dkarrasch |
Contributor
Author
|
It is for v1.10. We need to stop backporting stuff to v1.9 and release it |
Member
|
@KristofferC Are you able to review and merge this? |
Contributor
Author
|
bump |
Member
|
Seems like Julia doesn't like this: https://buildkite.com/julialang/julia-master/builds/25732#01893d2f-42d7-49b6-8641-699e5ccc7101/602-913, but it is surprising it only fails on mac. cc @Wimmerer |
Contributor
Author
|
There is a complementary PR for base to this that I have rebased locally, once this package is fixed and functional again I can push those |
Member
|
We need the PR to get this package merged into Base. Should we revert for now, get it all working and then get everything back in together? |
vtjnash
added a commit
that referenced
this pull request
Jul 12, 2023
This reverts commit 2c7f4d6 (#406), now that JuliaLang/julia#48977 is finished.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is type-piracy, but we cannot change that (until JuliaLang/julia#2326), so at least do not make these method intersections unnecessary slow and complicated for everyone who does not care about SparseArrays and does not load it, and unreliable for everyone who does load it.