bring coverage of fixed SparseMatrixCSC to 100%#392
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #392 +/- ##
==========================================
- Coverage 93.84% 92.19% -1.65%
==========================================
Files 12 12
Lines 7521 7521
==========================================
- Hits 7058 6934 -124
- Misses 463 587 +124
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dkarrasch
reviewed
May 26, 2023
Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
Member
|
Seems like there are still two untested methods: SparseMatrixCSC(m, n, colptr::ReadOnly, rowval::ReadOnly, nzval::Vector)
FixedSparseCSC{Tv,Ti}(x::AbstractSparseMatrixCSC) |
Member
|
@SobhanMP Any chance we can add coverage for the other two methods? Would be nice to get this PR in time for 1.10. |
Member
Author
|
@ViralBShah change in codecov seems unrelated, this should be 100% |
Member
Author
|
@dkarrasch can i merge? |
Member
|
Yes, go ahead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.