Add iszero(x) branches to xlogy and xlog1py#57
Merged
devmotion merged 11 commits intoJuliaStats:masterfrom Aug 23, 2022
Merged
Conversation
devmotion
reviewed
Aug 19, 2022
Member
devmotion
left a comment
devmotion
left a comment
There was a problem hiding this comment.
Hmm it seems there are still some test failures.
Contributor
Author
|
Hmm I saw them pass locally. Will get back to this... |
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
devmotion
reviewed
Aug 22, 2022
Contributor
Author
|
I needed to modify the |
Contributor
Author
|
I modified the wrong frule, apologies. |
devmotion
reviewed
Aug 22, 2022
devmotion
approved these changes
Aug 23, 2022
Member
devmotion
left a comment
devmotion
left a comment
There was a problem hiding this comment.
OK, let's get this in! It's definitely an improvement and tests pass finally 🙂 We can always add more branches later if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies for the new PR, but I accidentally deleted my remote branch. This replaces #54