do not constrain version#59
Merged
ranocha merged 2 commits intoJuliaVTK:mainfrom Aug 19, 2024
Merged
Conversation
Consistent information about VTK XML file formats, in particular on versions, is not available. Since recent versions of the VTK library still write out files labelled as version 0.1, not enforcing a particular version seems to be the best option at the moment.
Contributor
Author
|
I tried to understand what's going wrong. All errors are related to missing files in
I can reproduce it locally, but don't really understand what's going on. |
Member
|
I fixed the CI issues in #61. Thanks for your contribution! |
ranocha
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistent information about VTK XML file formats, in particular on versions, is not available.
Since recent versions of the VTK library still write out files labelled as version 0.1, not enforcing a particular version seems to be the best option at the moment.
Resolves #43