Open
Conversation
|
ping |
Contributor
|
For the |
Contributor
|
Here's a version that lessens the use of function renderdomchild(io, rctx::RenderContext, ctx, x)
if x isa Number || x isa AbstractString
printescaped(io, x, escapechild(ctx))
elseif x isa HTML
print(io, repr(MIME("text/html"), x))
else
showable(MIME("text/html"), x) ? print(io, repr(MIME("text/html"), x)) : printescaped(io, x, escapechild(ctx))
end
endHere's a test script: using Markdown, Hyperscript, BenchmarkTools
@tags div h1
@btime repr($(div("hello", h1("qwerqwer"), 33, "asdf")))
@btime repr($(div("hello", h1("qwerqwer"), 33, "asdf", md"*asdf* asdf")))
@btime repr($(div("hello", h1("qwerqwer"), 33, "asdf", HTML("<div>hello</div>"))))As a side note, |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surprisingly, broadcast seems to do really badly with empty lists & Vector{Any} results.
Removing the use of
showable()made the biggest difference. Of course this can't stay like it, and we'll need to figure out a why to optimize this without giving up the functionality.This branch, at least for my benchmark, is ~7x faster at constructing & rendering a dom!