fix: base64 encode and decoded in the binary encoder to avoid possible crash#20
Closed
gkachru wants to merge 2 commits intoJulien-R44:mainfrom
Closed
fix: base64 encode and decoded in the binary encoder to avoid possible crash#20gkachru wants to merge 2 commits intoJulien-R44:mainfrom
gkachru wants to merge 2 commits intoJulien-R44:mainfrom
Conversation
gkachru
changed the title
Contributor
|
We are also facing this issue. Can we speed up this review? |
Owner
|
Hey, thanks for the PR, but I think using base64 is not the best solution. I created a PR on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19 while passing the binary encode/decode tests