Skip to content

Add more sniffs 😈#21

Merged
dannewnsjump24 merged 2 commits intomainfrom
feature/stricter-standards
Feb 28, 2023
Merged

Add more sniffs 😈#21
dannewnsjump24 merged 2 commits intomainfrom
feature/stricter-standards

Conversation

@mantebalzaraviciute
Copy link
Contributor

@mantebalzaraviciute mantebalzaraviciute commented Feb 28, 2023

Added more sniffs to enforce stricter coding standards and catch issues commonly requested or missed in code reviews.

$services->set(DisallowEqualOperatorsSniff::class);
What: Disallows the use of == and != and enforces the use of === and !==
Why: Enforcing type-strict comparisons will make our code stricter and safer from unexpected conversions

$services->set(TraitUseDeclarationSniff::class);
What: Enforce multiple use statements instead of comma separating traits
Why: We do that anyway and it will do it for us 😅 Provides better organisation and makes it more readable

$services->set(DeclareStrictTypesSniff::class);
What: Will add declare(strict_types=1); at the top of each file
Why: Stricter typing 👍🏻 and makes the app more robust

$services->set(ReturnTypeHintSniff::class);
What: Enforces return type hints
Why: Developer experience, neater code and readability

$services->set(UselessTernaryOperatorSniff::class);
What: Removes useless statements where both sides return true or false
Why: Removes stale code that is not needed

$services->set(DisallowMixedTypeHintSniff::class);
What: No mixed type hints allowed 🚫
Why: 👆🏻

$services->set(ParameterTypeHintSniff::class);
What: Enforces parameter type hints
Why: Makes it more readable, consistent and improves developer experience

$services->set(SingleLineArrayWhitespaceSniff::class)
What: Ensures that there is no whitespace between array brackets and first/last key
Why: Consistency with our current standards

@dannewnsjump24 dannewnsjump24 merged commit d0d0ed4 into main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants