Merged
Conversation
dannewnsjump24
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added more sniffs to enforce stricter coding standards and catch issues commonly requested or missed in code reviews.
$services->set(DisallowEqualOperatorsSniff::class);What: Disallows the use of
==and!=and enforces the use of===and!==Why: Enforcing type-strict comparisons will make our code stricter and safer from unexpected conversions
$services->set(TraitUseDeclarationSniff::class);What: Enforce multiple use statements instead of comma separating traits
Why: We do that anyway and it will do it for us 😅 Provides better organisation and makes it more readable
$services->set(DeclareStrictTypesSniff::class);What: Will add
declare(strict_types=1);at the top of each fileWhy: Stricter typing 👍🏻 and makes the app more robust
$services->set(ReturnTypeHintSniff::class);What: Enforces return type hints
Why: Developer experience, neater code and readability
$services->set(UselessTernaryOperatorSniff::class);What: Removes useless statements where both sides return true or false
Why: Removes stale code that is not needed
$services->set(DisallowMixedTypeHintSniff::class);What: No mixed type hints allowed 🚫
Why: 👆🏻
$services->set(ParameterTypeHintSniff::class);What: Enforces parameter type hints
Why: Makes it more readable, consistent and improves developer experience
$services->set(SingleLineArrayWhitespaceSniff::class)What: Ensures that there is no whitespace between array brackets and first/last key
Why: Consistency with our current standards