Skip to content

Comments

Add tip counter#1

Open
mmalykov wants to merge 2 commits intomasterfrom
add-tip-counter
Open

Add tip counter#1
mmalykov wants to merge 2 commits intomasterfrom
add-tip-counter

Conversation

@mmalykov
Copy link
Collaborator

No description provided.

@AliceAponasko
Copy link
Member

AliceAponasko commented Sep 14, 2016

Please connect linter! I will not be commenting typos on styleguide, please do that with linter.

@AliceAponasko
Copy link
Member

AliceAponasko commented Sep 14, 2016

unspecified

Not clear what to do in the initial screen, sumCountTextField should be focused so the keyboard will be up.

@AliceAponasko
Copy link
Member

AliceAponasko commented Sep 14, 2016

unspecified

iPhone 5
unspecified

@AliceAponasko
Copy link
Member

AliceAponasko commented Sep 14, 2016

The app doesn't show the bar in landscape mode (Command + ➡ in simulator).
Option 1: figure out an interface for landscape for every phone with constraints
Option 2: disable landscape rotation for the app (since the samvlu design does not specify landscape)

@AliceAponasko
Copy link
Member

App crashes if no value is specified and Done clicked


import Foundation

extension Double {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AliceAponasko
Copy link
Member

Great idea with the Sum struct! 👏
How about adding couple unit tests to this project? I can help.

Copy link
Member

@AliceAponasko AliceAponasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter + design + all the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants