Skip to content

Update .travis.yml#69

Merged
karlwilbur merged 3 commits intoK-and-R:developfrom
nageshlop:master
Dec 14, 2020
Merged

Update .travis.yml#69
karlwilbur merged 3 commits intoK-and-R:developfrom
nageshlop:master

Conversation

@nageshlop
Copy link
Contributor

This PR adds CI support for the IBM Power Little Endian (ppc64le) architecture. The idea is to ensure that the builds on this architecture are continuously tested along with the Intel builds (amd64) as this is part of the ubuntu distro on that architecture as well and detecting (and fixing) any issues or failures early would help to ensure that we are always up to date.
The build and test results are available at the below location.
https://travis-ci.com/github/nageshlop/email_validator

karlwilbur and others added 3 commits December 10, 2020 18:54
* develop:
  Bump version to `2.2.1`
  Add `rubocop-rake` to dev dependencies
  Enforce domain character limit
  Allow mailbox-only addresses  in `:rfc` mode
  Fix regexp for numeric subdomains (fixes #68)
  [specs] Add tests for numeric subdomains
* develop:
  Bump version to `2.2.2`
  Fix includes for :rfc and :strict modes from Gemfile
@karlwilbur karlwilbur changed the base branch from master to develop December 14, 2020 17:26
Copy link
Member

@karlwilbur karlwilbur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@karlwilbur karlwilbur merged commit 22dee68 into K-and-R:develop Dec 14, 2020
@karlwilbur
Copy link
Member

I will merged this into master with the next update.

@nageshlop
Copy link
Contributor Author

Thanks for the consideration.

@karlwilbur
Copy link
Member

karlwilbur commented Apr 6, 2021

@nageshlop

Any idea why this is failing in master for Ruby 2.4.x?
https://travis-ci.com/github/K-and-R/email_validator

I am seeing that the activerecord is pulled in at version 5 for amd64 but pulled it at version 6 for ppc64le. For Ruby versions > 2.4, the version 6 is fine, as is expected. This was not occurring in the PR branch, nor in develop when the PR was merged into the develop branch. This is only now happening in master after this commit was merged into master.

In the non-master builds, Bundler was pulling in version 5 of ActiveRecord for the Ruby version 2.4.x.

I suspect that I may be able to just rebuild this failed build and possibly have it work, however TravisCI is apparently broken at the moment: https://travis-ci.community/t/oh-no-an-error-occurred-the-job-could-not-be-restarted/11193

@nageshlop
Copy link
Contributor Author

Hi @karlwilbur
I verified the test by executing travis build on master branch. I was also observing timeout issue, after retrying the build it is successful. Looks intermittent issue in connecting host. Could you rerun the build and check. The build logs are as mentioned below.
Successful build log:
https://travis-ci.com/github/nageshlop/email_validator/builds/222362933
Error:
https://travis-ci.com/github/nageshlop/email_validator/builds/222357740

@karlwilbur
Copy link
Member

I am going to create an issue for tracking this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants