Merged
Conversation
* develop: Bump version to `2.2.3` Fix regexp for numeric domains (fixes K-and-R#72) Add `EmailValidator::Error` class, raise `EmailValidator::Error` when invalid `mode` Add checks for double dash in domain Fix specs for numeric-only domains labels Add checks for numeric-only TLDs in tests Add tests to ensure that `regexp` returns expected value Bump y18n from 3.2.1 to 3.2.2 Add failing test: strict mode should accept numbers only domains Update .travis.yml
fix a typo in README
Previous link to David Gilbertson's article was a broken hackernoon link, as well as the same hackernoon link on David's profile page on hackernoon. this PR just changes the link to a viable medium link, which is still written by David Gilbertson, so he retains all credit.
Member
|
Thank you, @msands. |
karlwilbur
approved these changes
Sep 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous link to David Gilbertson's article was a broken hackernoon link, as well as the same hackernoon link on David's profile page on hackernoon.
this PR just changes the link to a viable medium link, which is still written by David Gilbertson, so he retains all credit.