Draft
Conversation
rflechtner
reviewed
May 29, 2024
Contributor
rflechtner
left a comment
rflechtner
left a comment
There was a problem hiding this comment.
This changeset seems a little inconsistent; I would either expect an empty versions file as generated by yarn version patch or a patch instruction in the version file but no change to the package.json, as resulting from yarn version patch -d. This changeset looks like you edited the package.json by hand.
Contributor
Author
@rflechtner ops I did... I am not sure I still understand how |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.