Merged
Conversation
rflechtner
reviewed
Oct 28, 2024
rflechtner
reviewed
Oct 28, 2024
code_examples/sdk_examples/src/workshop/issuer/generateAccount.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
…nto 3594-update-workshop Signed-off-by: Chris Chinchilla <chris@kilt.io> # Conflicts: # sdk/02_tutorial/03_overview.md
Signed-off-by: Chris Chinchilla <chris@kilt.io>
rflechtner
reviewed
Oct 29, 2024
Contributor
rflechtner
left a comment
rflechtner
left a comment
There was a problem hiding this comment.
Nice! Just some nitpicks remaining
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Author
|
@rflechtner If you're good with it now, let's get this merged into the SDK branch and I will fix the code transclusion now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#3594