Conversation
Contributor
Author
|
CI failure proves my point of adding this to the CI. They should be fixed after merging #235 as mentioned above. |
Contributor
|
Should we add |
Contributor
Author
Yeah, that sounds good. |
weichweich
approved these changes
Aug 9, 2021
Contributor
weichweich
left a comment
There was a problem hiding this comment.
my only objection is that this will increase the load on the server. We have 2 concurrent jobs at the moment. Maybe we should increase that to 3 or 4. 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No ticket
In #231 none of the CI tests failed but
cargo testwas broken for the did pallet. This should be fixed by #235. However, in #235 we stumbled into the same error. Thus, I think we should add a separate `cargo test step to the CI as proposed here.Checklist:
array[3]useget(3), ...)