Merged
Conversation
weichweich
approved these changes
Oct 25, 2021
wischli
approved these changes
Oct 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No-Ticket
The integration tests on the SDK were failing, because the docker image for the standalone chain was panicking with following error:
Here is someone else having the same problem: paritytech/substrate#9984
I modified the Dockerfile to include the certificates. I was following substrates maintain Dockerfile here: https://github.com/paritytech/substrate/blob/7fbec2f9d22adc6bf968a048d768b2e30b46ac30/.maintain/docker/substrate.Dockerfile
It might not be necessary to switch to the ubuntu image. I did that, because I couldn't install anything in the docker image manually (while running it with
/bin/bash) and substrate has switched to it: paritytech/substrate#9753. It turns out, that apt-get and similar are missing, because the wholeusrbinaries are removed: https://github.com/KILTprotocol/mashnet-node/blob/develop/Dockerfile#L34.Do we really need to remove all these binaries?
Is it ok to switch to the ubuntu image?
Checklist:
array[3]useget(3), ...)