Merged
Conversation
ntn-x2
reviewed
Aug 9, 2022
Contributor
ntn-x2
left a comment
ntn-x2
left a comment
There was a problem hiding this comment.
Very nice cleanups! I just have a couple of questions.
runtimes/clone/Cargo.toml
Outdated
| pallet-transaction-payment-rpc-runtime-api = {git = "https://github.com/paritytech/substrate", default-features = false, branch = "polkadot-v0.9.27"} | ||
|
|
||
| # KILT pallets & primitives | ||
| kilt-support = {path = "../../support", default-features = false, optional = true} |
Contributor
There was a problem hiding this comment.
Was this failing? Or why did you add it in?
Contributor
Author
There was a problem hiding this comment.
It was a clippy complaint
Contributor
There was a problem hiding this comment.
Interesting. Mine does not, plus I do not see it being used anywhere inside that crate. I see that its usage has been commented out as part of the // TODO: Enable after adding delegation pallet, so that is probably the reason. If we don't plan to uncomment those, then perhaps we can remove it from the Cargo file as well?
Contributor
Author
There was a problem hiding this comment.
You are right, I suppose I added these comments after I added it to the dependencies. Fixed in 75c4255
weichweich
approved these changes
Aug 9, 2022
wischli
added a commit
that referenced
this pull request
Aug 30, 2022
* feat: upgrade to Polkadot v0.9.27 * chore: bump nightly, sr-tool, base docker img * fix: clippy clone runtime * fix: clippy * fix: remove deprecated license fmt checker rust-lang/rustfmt#5103 * fix: clippy 2 * fix: clone * chore: bump sub deps * fix: clippy * chore: bump serde * ci: fix bump srtool to 1.62.0 * fix: remove kilt-support dep from clone runtime * ci: bump parity base img
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#2130
rustc 1.64.0-nightly (7fe022f5a 2022-07-24)from2022-05-301.62.0from1.60.0Eqto be derived whenPartialEqis implemented)cloneruntimelicense_template_pathrust-lang/rustfmt#5103 )Note worthy Substrate PRs
benchmark extrinsiccommand paritytech/substrate#11456ChainExtensionparitytech/substrate#11816Migrations
TODO
Checklist:
array[3]useget(3), ...)