feat: remove dyn filter & relay migration#411
Merged
weichweich merged 5 commits intomasterfrom Sep 27, 2022
Merged
Conversation
wischli
reviewed
Sep 15, 2022
wischli
reviewed
Sep 20, 2022
runtimes/common/src/migrations.rs
Outdated
Comment on lines
+33
to
+42
| let has_storage = frame_support::storage::migration::have_storage_value( | ||
| b"RelayMigration", | ||
| b"RelayNumberStrictlyIncreases", | ||
| b"", | ||
| ) && frame_support::storage::migration::have_storage_value(b"DynFilter", b"Filter", b""); | ||
| if has_storage { | ||
| Ok(()) | ||
| } else { | ||
| Err("Pallets not present") | ||
| } |
Contributor
There was a problem hiding this comment.
W: Use ensure instead separated for both pallets.
runtimes/common/src/migrations.rs
Outdated
Comment on lines
+49
to
+50
| let _ = frame_support::storage::unhashed::clear_prefix(&Twox128::hash(b"RelayMigration"), Some(entries), None); | ||
| let _ = frame_support::storage::unhashed::clear_prefix(&Twox128::hash(b"DynFilter"), Some(entries), None); |
Contributor
There was a problem hiding this comment.
S: Add least post some success and debug message based on the result of the clearing.
wischli
pushed a commit
that referenced
this pull request
Oct 2, 2022
* feat: remove dyn filter & relay migration * 🧹🐢 * feat: migration to remove storage * better logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
array[3]useget(3), ...)